Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a4415f39 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

dm integrity: fix error code in dm_integrity_ctr() 



commit d3f2a14b8906df913cb04a706367b012db94a6e8 upstream.

The "r" variable shadows an earlier "r" that has function scope.  It
means that we accidentally return success instead of an error code.
Smatch has a warning for this:

	drivers/md/dm-integrity.c:4503 dm_integrity_ctr()
	warn: missing error code 'r'

Fixes: 7eada909 ("dm: add integrity target")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarMikulas Patocka <mpatocka@redhat.com>
Signed-off-by: default avatarMike Snitzer <snitzer@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fc658c08

drivers/md/dm-integrity.c

+0 −2
Original line number Diff line number Diff line
@@ -4149,8 +4149,6 @@ static int dm_integrity_ctr(struct dm_target *ti, unsigned argc, char **argv) 
	}



	if (should_write_sb) {

		int r;



		init_journal(ic, 0, ic->journal_sections, 0);

		r = dm_integrity_failed(ic);

		if (unlikely(r)) {