Commit a3c5386a authored Oct 08, 2021 by Fabio Estevam Committed by Greg Kroah-Hartman Jan 27, 2022

media: imx-pxp: Initialize the spinlock prior to using it



[ Upstream commit ed2f97ad4b21072f849cf4ae6645d1f2b1d3f550 ]

After devm_request_threaded_irq() is called there is a chance that an
interrupt may occur before the spinlock is initialized, which will trigger
a kernel oops.

To prevent that, move the initialization of the spinlock prior to
requesting the interrupts.

Fixes: 51abcf7f ("media: imx-pxp: add i.MX Pixel Pipeline driver")
Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 0410f7ac

drivers/media/platform/imx-pxp.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1664,6 +1664,8 @@ static int pxp_probe(struct platform_device *pdev)
		if (irq < 0)
		return irq;

		spin_lock_init(&dev->irqlock);

		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, pxp_irq_handler,
		IRQF_ONESHOT, dev_name(&pdev->dev), dev);
		if (ret < 0) {
		@@ -1681,8 +1683,6 @@ static int pxp_probe(struct platform_device *pdev)
		goto err_clk;
		}

		spin_lock_init(&dev->irqlock);

		ret = v4l2_device_register(&pdev->dev, &dev->v4l2_dev);
		if (ret)
		goto err_clk;