Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a391bced authored by Dmitry Rokosov's avatar Dmitry Rokosov Committed by Greg Kroah-Hartman
Browse files

iio:accel:mxc4005: rearrange iio trigger get and register 



commit 9354c224c9b4f55847a0de3e968cba2ebf15af3b upstream.

IIO trigger interface function iio_trigger_get() should be called after
iio_trigger_register() (or its devm analogue) strictly, because of
iio_trigger_get() acquires module refcnt based on the trigger->owner
pointer, which is initialized inside iio_trigger_register() to
THIS_MODULE.
If this call order is wrong, the next iio_trigger_put() (from sysfs
callback or "delete module" path) will dereference "default" module
refcnt, which is incorrect behaviour.

Fixes: 47196620 ("iio: mxc4005: add data ready trigger for mxc4005")
Signed-off-by: default avatarDmitry Rokosov <ddrokosov@sberdevices.ru>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20220524181150.9240-4-ddrokosov@sberdevices.ru


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 23c158ca

drivers/iio/accel/mxc4005.c

+2 −2
Original line number Diff line number Diff line
@@ -462,8 +462,6 @@ static int mxc4005_probe(struct i2c_client *client, 
		data->dready_trig->dev.parent = &client->dev;

		data->dready_trig->ops = &mxc4005_trigger_ops;

		iio_trigger_set_drvdata(data->dready_trig, indio_dev);

		indio_dev->trig = data->dready_trig;

		iio_trigger_get(indio_dev->trig);

		ret = devm_iio_trigger_register(&client->dev,

						data->dready_trig);

		if (ret) {
@@ -471,6 +469,8 @@ static int mxc4005_probe(struct i2c_client *client, 
				"failed to register trigger\n");

			return ret;

		}



		indio_dev->trig = iio_trigger_get(data->dready_trig);

	}



	return devm_iio_device_register(&client->dev, indio_dev);