Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a2ceb1fb authored by Robert Love's avatar Robert Love
Browse files

libfcoe: Fix meaningless log statement 



ctlr_dev was initialized to NULL, and never re-assigned. This
caused the log statement to always report failure. This patch
removes the unused variable and fixes the log statement to always
report 'success', as that is what should be logged if the code
reaches this point.

Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
Tested-by: default avatarJack Morgan <jack.morgan@intel.com>
Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
parent 3a292605

drivers/scsi/fcoe/fcoe_transport.c

+2 −4
Original line number Diff line number Diff line
@@ -707,7 +707,6 @@ ssize_t fcoe_ctlr_create_store(struct bus_type *bus, 
{

	struct net_device *netdev = NULL;

	struct fcoe_transport *ft = NULL;

	struct fcoe_ctlr_device *ctlr_dev = NULL;

	int rc = 0;

	int err;
@@ -754,9 +753,8 @@ ssize_t fcoe_ctlr_create_store(struct bus_type *bus, 
		goto out_putdev;

	}



	LIBFCOE_TRANSPORT_DBG("transport %s %s to create fcoe on %s.\n",

			      ft->name, (ctlr_dev) ? "succeeded" : "failed",

			      netdev->name);

	LIBFCOE_TRANSPORT_DBG("transport %s succeeded to create fcoe on %s.\n",

			      ft->name, netdev->name);



out_putdev:

	dev_put(netdev);