Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a2bf74f4 authored by Venkat Duvvuru's avatar Venkat Duvvuru Committed by David S. Miller
Browse files

bnxt_en: free hwrm resources, if driver probe fails. 



When the driver probe fails, all the resources that were allocated prior
to the failure must be freed. However, hwrm dma response memory is not
getting freed.

This patch fixes the problem described above.

Fixes: c0c050c5 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: default avatarVenkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5db0e096

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+6 −4
Original line number Original line Diff line number Diff line
@@ -3017,11 +3017,12 @@ static void bnxt_free_hwrm_resources(struct bnxt *bp) 
{

{

	struct pci_dev *pdev = bp->pdev;

	struct pci_dev *pdev = bp->pdev;





	if (bp->hwrm_cmd_resp_addr) {

		dma_free_coherent(&pdev->dev, PAGE_SIZE, bp->hwrm_cmd_resp_addr,

		dma_free_coherent(&pdev->dev, PAGE_SIZE, bp->hwrm_cmd_resp_addr,

				  bp->hwrm_cmd_resp_dma_addr);

				  bp->hwrm_cmd_resp_dma_addr);



		bp->hwrm_cmd_resp_addr = NULL;

		bp->hwrm_cmd_resp_addr = NULL;

	}

	}

}





static int bnxt_alloc_hwrm_resources(struct bnxt *bp)

static int bnxt_alloc_hwrm_resources(struct bnxt *bp)

{

{
@@ -9057,6 +9058,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) 
	bnxt_clear_int_mode(bp);

	bnxt_clear_int_mode(bp);





init_err_pci_clean:

init_err_pci_clean:

	bnxt_free_hwrm_resources(bp);

	bnxt_cleanup_pci(bp);

	bnxt_cleanup_pci(bp);





init_err_free:

init_err_free: