Commit a2a94e73 authored Mar 31, 2011 by Paul Bolle Committed by Dmitry Torokhov Mar 31, 2011

Input: i8042 - downgrade selftest error message to dbg()



On a "really fragile" laptop I noticed a single
    i8042.c: i8042 controller selftest failed. (0x1 != 0x55)

error in the log. But there's no reason to print this message at
KERN_ERR level each time that loop fails, especially since the message
telling about the overall selftest failure is printed at KERN_INFO level
(on X86).

Add an actual error message for non-X86 systems, where a selftest
failure is (apparently) more serious. Remove a space in an another error
message.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

parent 70874867

drivers/input/serio/i8042.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -876,7 +876,7 @@ static int i8042_controller_selftest(void)
		if (param == I8042_RET_CTL_TEST)
		return 0;

		pr_err("i8042 controller selftest failed. (%#x != %#x)\n",
		dbg("i8042 controller selftest: %#x != %#x\n",
		param, I8042_RET_CTL_TEST);
		msleep(50);
		} while (i++ < 5);
		@@ -891,6 +891,7 @@ static int i8042_controller_selftest(void)
		pr_info("giving up on controller selftest, continuing anyway...\n");
		return 0;
		#else
		pr_err("i8042 controller selftest failed\n");
		return -EIO;
		#endif
		}