Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a256f2e3 authored by Anup Patel's avatar Anup Patel Committed by Paul Walmsley
Browse files

RISC-V: Fix FIXMAP area corruption on RV32 systems 



Currently, various virtual memory areas of Linux RISC-V are organized
in increasing order of their virtual addresses is as follows:
1. User space area (This is lowest area and starts at 0x0)
2. FIXMAP area
3. VMALLOC area
4. Kernel area (This is highest area and starts at PAGE_OFFSET)

The maximum size of user space aread is represented by TASK_SIZE.

On RV32 systems, TASK_SIZE is defined as VMALLOC_START which causes the
user space area to overlap the FIXMAP area. This allows user space apps
to potentially corrupt the FIXMAP area and kernel OF APIs will crash
whenever they access corrupted FDT in the FIXMAP area.

On RV64 systems, TASK_SIZE is set to fixed 256GB and no other areas
happen to overlap so we don't see any FIXMAP area corruptions.

This patch fixes FIXMAP area corruption on RV32 systems by setting
TASK_SIZE to FIXADDR_START. We also move FIXADDR_TOP, FIXADDR_SIZE,
and FIXADDR_START defines to asm/pgtable.h so that we can avoid cyclic
header includes.

Signed-off-by: default avatarAnup Patel <anup.patel@wdc.com>
Tested-by: default avatarAlistair Francis <alistair.francis@wdc.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarPaul Walmsley <paul.walmsley@sifive.com>
parent a55aa89a

arch/riscv/include/asm/fixmap.h

+0 −4
Original line number Diff line number Diff line
@@ -30,10 +30,6 @@ enum fixed_addresses { 
	__end_of_fixed_addresses

};



#define FIXADDR_SIZE		(__end_of_fixed_addresses * PAGE_SIZE)

#define FIXADDR_TOP		(VMALLOC_START)

#define FIXADDR_START		(FIXADDR_TOP - FIXADDR_SIZE)



#define FIXMAP_PAGE_IO		PAGE_KERNEL



#define __early_set_fixmap	__set_fixmap

arch/riscv/include/asm/pgtable.h

+10 −2
Original line number Diff line number Diff line
@@ -420,14 +420,22 @@ static inline void pgtable_cache_init(void) 
#define VMALLOC_END      (PAGE_OFFSET - 1)

#define VMALLOC_START    (PAGE_OFFSET - VMALLOC_SIZE)



#define FIXADDR_TOP      VMALLOC_START

#ifdef CONFIG_64BIT

#define FIXADDR_SIZE     PMD_SIZE

#else

#define FIXADDR_SIZE     PGDIR_SIZE

#endif

#define FIXADDR_START    (FIXADDR_TOP - FIXADDR_SIZE)



/*

 * Task size is 0x4000000000 for RV64 or 0xb800000 for RV32.

 * Task size is 0x4000000000 for RV64 or 0x9fc00000 for RV32.

 * Note that PGDIR_SIZE must evenly divide TASK_SIZE.

 */

#ifdef CONFIG_64BIT

#define TASK_SIZE (PGDIR_SIZE * PTRS_PER_PGD / 2)

#else

#define TASK_SIZE VMALLOC_START

#define TASK_SIZE FIXADDR_START

#endif



#include <asm-generic/pgtable.h>