Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1ceeca6 authored by Gal Pressman's avatar Gal Pressman Committed by Jason Gunthorpe
Browse files

RDMA/hns: Fix usage of bitmap allocation functions return values 



hns bitmap allocation functions return 0 on success and -1 on failure.
Callers of these functions wrongly used their return value as an errno,
fix that by making a proper conversion.

Fixes: a598c6f4 ("IB/hns: Simplify function of pd alloc and qp alloc")
Signed-off-by: default avatarGal Pressman <pressmangal@gmail.com>
Acked-by: default avatarLijun Ou <oulijun@huawei.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent dd81b2c8

drivers/infiniband/hw/hns/hns_roce_pd.c

+1 −1
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ 


static int hns_roce_pd_alloc(struct hns_roce_dev *hr_dev, unsigned long *pdn)

{

	return hns_roce_bitmap_alloc(&hr_dev->pd_bitmap, pdn);

	return hns_roce_bitmap_alloc(&hr_dev->pd_bitmap, pdn) ? -ENOMEM : 0;

}



static void hns_roce_pd_free(struct hns_roce_dev *hr_dev, unsigned long pdn)

drivers/infiniband/hw/hns/hns_roce_qp.c

+4 −1
Original line number Diff line number Diff line
@@ -115,7 +115,10 @@ static int hns_roce_reserve_range_qp(struct hns_roce_dev *hr_dev, int cnt, 
{

	struct hns_roce_qp_table *qp_table = &hr_dev->qp_table;



	return hns_roce_bitmap_alloc_range(&qp_table->bitmap, cnt, align, base);

	return hns_roce_bitmap_alloc_range(&qp_table->bitmap, cnt, align,

					   base) ?

		       -ENOMEM :

		       0;

}



enum hns_roce_qp_state to_hns_roce_state(enum ib_qp_state state)