Commit a19a0582 authored Jun 06, 2019 by Fabio Estevam Committed by David S. Miller Jun 06, 2019

net: fec: Do not use netdev messages too early



When a valid MAC address is not found the current messages
are shown:

fec 2188000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00
fec 2188000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: aa:9f:25:eb:7e:aa

Since the network device has not been registered at this point, it is better
to use dev_err()/dev_info() instead, which will provide cleaner log
messages like these:

fec 2188000.ethernet: Invalid MAC address: 00:00:00:00:00:00
fec 2188000.ethernet: Using random MAC address: aa:9f:25:eb:7e:aa

Tested on a imx6dl-pico-pi board.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fe1e0713

drivers/net/ethernet/freescale/fec_main.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1689,9 +1689,9 @@ static void fec_get_mac(struct net_device *ndev)
		*/
		if (!is_valid_ether_addr(iap)) {
		/* Report it and use a random ethernet address instead */
		netdev_err(ndev, "Invalid MAC address: %pM\n", iap);
		dev_err(&fep->pdev->dev, "Invalid MAC address: %pM\n", iap);
		eth_hw_addr_random(ndev);
		netdev_info(ndev, "Using random MAC address: %pM\n",
		dev_info(&fep->pdev->dev, "Using random MAC address: %pM\n",
		ndev->dev_addr);
		return;
		}