Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a133d930 authored by Geliang Tang's avatar Geliang Tang Committed by Steffen Klassert
Browse files

xfrm: use memdup_user 



Use memdup_user() helper instead of open-coding to simplify the code.

Signed-off-by: default avatarGeliang Tang <geliangtang@gmail.com>
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent a95cfad9

net/xfrm/xfrm_state.c

+3 −8
Original line number Diff line number Diff line
@@ -2023,13 +2023,9 @@ int xfrm_user_policy(struct sock *sk, int optname, u8 __user *optval, int optlen 
	if (optlen <= 0 || optlen > PAGE_SIZE)

		return -EMSGSIZE;



	data = kmalloc(optlen, GFP_KERNEL);

	if (!data)

		return -ENOMEM;



	err = -EFAULT;

	if (copy_from_user(data, optval, optlen))

		goto out;

	data = memdup_user(optval, optlen);

	if (IS_ERR(data))

		return PTR_ERR(data);



	err = -EINVAL;

	rcu_read_lock();
@@ -2047,7 +2043,6 @@ int xfrm_user_policy(struct sock *sk, int optname, u8 __user *optval, int optlen 
		err = 0;

	}



out:

	kfree(data);

	return err;

}