Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a117dddf authored by Jean Delvare's avatar Jean Delvare Committed by Jean Delvare
Browse files

hwmon/f71805f: Fix a race condition 



I think I introduced a potential race condition bug with commit
51c997d8. I didn't realize it
back then, but platform_device_put and platform_device_release
both appear to free the platform data associated with the device.
This makes an explicit kfree redundant at best, and maybe even
racy, as it might occur while someone still holds a reference
to the platform device.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
parent bc8f0a26

drivers/hwmon/f71805f.c

+1 −7
Original line number Diff line number Diff line
@@ -1290,14 +1290,11 @@ static int __init f71805f_device_add(unsigned short address, 
	if (err) {

		printk(KERN_ERR DRVNAME ": Device addition failed (%d)\n",

		       err);

		goto exit_kfree_data;

		goto exit_device_put;

	}



	return 0;



exit_kfree_data:

	kfree(pdev->dev.platform_data);

	pdev->dev.platform_data = NULL;

exit_device_put:

	platform_device_put(pdev);

exit:
@@ -1390,10 +1387,7 @@ static int __init f71805f_init(void) 


static void __exit f71805f_exit(void)

{

	kfree(pdev->dev.platform_data);

	pdev->dev.platform_data = NULL;

	platform_device_unregister(pdev);



	platform_driver_unregister(&f71805f_driver);

}