Commit a107311d authored Feb 01, 2018 by Desnes Augusto Nunes do Rosario Committed by David S. Miller Feb 01, 2018

ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

Older versions of VIOS servers do not send the firmware level in the VPD
buffer for the ibmvnic driver. Thus, not only the current message is mis-
leading but the firmware version in the ethtool will be NULL. Therefore,
this patch fixes the firmware string and its warning.

Fixes: 4e6759be ("ibmvnic: Feature implementation of VPD for the ibmvnic driver")
Signed-off-by: Desnes A. Nunes do Rosario <desnesn@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5e264e2b

drivers/net/ethernet/ibm/ibmvnic.c

+5 −1

Original line number	Original line	Diff line number	Diff line
	@@ -3305,7 +3305,11 @@ static void handle_vpd_rsp(union ibmvnic_crq *crq,
	*/		*/
	substr = strnstr(adapter->vpd->buff, "RM", adapter->vpd->len);		substr = strnstr(adapter->vpd->buff, "RM", adapter->vpd->len);
	if (!substr) {		if (!substr) {
	dev_info(dev, "No FW level provided by VPD\n");		dev_info(dev, "Warning - No FW level has been provided in the VPD buffer by the VIOS Server\n");
			ptr = strncpy((char *)adapter->fw_version, "N/A",
			3 * sizeof(char));
			if (!ptr)
			dev_err(dev, "Failed to inform that firmware version is unavailable to the adapter\n");
	goto complete;		goto complete;
	}		}