Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a10674bf authored by Vasily Averin's avatar Vasily Averin Committed by David S. Miller
Browse files

tcp: detecting the misuse of .sendpage for Slab objects 



sendpage was not designed for processing of the Slab pages,
in some situations it can trigger BUG_ON on receiving side.

Signed-off-by: default avatarVasily Averin <vvs@virtuozzo.com>
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7b837623

net/ipv4/tcp.c

+4 −0
Original line number Diff line number Diff line
@@ -943,6 +943,10 @@ ssize_t do_tcp_sendpages(struct sock *sk, struct page *page, int offset, 
	ssize_t copied;

	long timeo = sock_sndtimeo(sk, flags & MSG_DONTWAIT);



	if (IS_ENABLED(CONFIG_DEBUG_VM) &&

	    WARN_ONCE(PageSlab(page), "page must not be a Slab one"))

		return -EINVAL;



	/* Wait for a connection to finish. One exception is TCP Fast Open

	 * (passive side) where data is allowed to be sent before a connection

	 * is fully established.