Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a08b9e9a authored by Selvin Xavier's avatar Selvin Xavier Committed by Jason Gunthorpe
Browse files

RDMA/bnxt_re: Wait for delayed work to finish before device removal 



Delayed work bnxt_re_worker would be still running even after
cancel_delayed_work returns. This causes crash as the driver proceeds with
device removal. To make sure that the work is finished before returning,
use cancel_delayed_work_sync.

Signed-off-by: default avatarSelvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 854a2020

drivers/infiniband/hw/bnxt_re/main.c

+1 −1
Original line number Diff line number Diff line
@@ -1203,7 +1203,7 @@ static void bnxt_re_ib_unreg(struct bnxt_re_dev *rdev) 
		bnxt_re_unregister_ib(rdev);

	}

	if (test_and_clear_bit(BNXT_RE_FLAG_QOS_WORK_REG, &rdev->flags))

		cancel_delayed_work(&rdev->worker);

		cancel_delayed_work_sync(&rdev->worker);



	bnxt_re_cleanup_res(rdev);

	bnxt_re_free_res(rdev);