Commit a07b4895 authored Jan 02, 2023 by Daniil Tatianin Committed by Greg Kroah-Hartman Jan 18, 2023

drivers/net/bonding/bond_3ad: return when there's no aggregator



[ Upstream commit 9c807965483f42df1d053b7436eedd6cf28ece6f ]

Otherwise we would dereference a NULL aggregator pointer when calling
__set_agg_ports_ready on the line below.

Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2f7a09c1

drivers/net/bonding/bond_3ad.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1529,6 +1529,7 @@ static void ad_port_selection_logic(struct port port, bool update_slave_arr)
		slave_err(bond->dev, port->slave->dev,
		"Port %d did not find a suitable aggregator\n",
		port->actor_port_number);
		return;
		}
		}
		/* if all aggregator's ports are READY_N == TRUE, set ready=TRUE