Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0644050 authored by Mans Rullgard's avatar Mans Rullgard Committed by Greg Kroah-Hartman
Browse files

net: dsa: lan9303: fix reset on probe 



commit 6bb9681a43f34f2cab4aad6e2a02da4ce54d13c5 upstream.

The reset input to the LAN9303 chip is active low, and devicetree
gpio handles reflect this.  Therefore, the gpio should be requested
with an initial state of high in order for the reset signal to be
asserted.  Other uses of the gpio already use the correct polarity.

Fixes: a1292595 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")
Signed-off-by: default avatarMans Rullgard <mans@mansr.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarFlorian Fianelil <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20220209145454.19749-1-mans@mansr.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 73f85752

drivers/net/dsa/lan9303-core.c

+1 −1
Original line number Diff line number Diff line
@@ -1303,7 +1303,7 @@ static int lan9303_probe_reset_gpio(struct lan9303 *chip, 
				     struct device_node *np)

{

	chip->reset_gpio = devm_gpiod_get_optional(chip->dev, "reset",

						   GPIOD_OUT_LOW);

						   GPIOD_OUT_HIGH);

	if (IS_ERR(chip->reset_gpio))

		return PTR_ERR(chip->reset_gpio);