Commit a00b4e0f authored Nov 23, 2022 by Xiu Jianfeng Committed by Greg Kroah-Hartman Jan 18, 2023

clk: samsung: Fix memory leak in _samsung_clk_register_pll()



[ Upstream commit 5174e5b0d1b669a489524192b6adcbb3c54ebc72 ]

If clk_register() fails, @pll->rate_table may have allocated memory by
kmemdup(), so it needs to be freed, otherwise will cause memory leak
issue, this patch fixes it.

Fixes: 3ff6e0d8 ("clk: samsung: Add support to register rate_table for samsung plls")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Link: https://lore.kernel.org/r/20221123032015.63980-1-xiujianfeng@huawei.com


Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 7a2c6642

drivers/clk/samsung/clk-pll.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1390,6 +1390,7 @@ static void __init _samsung_clk_register_pll(struct samsung_clk_provider *ctx,
		if (ret) {
		pr_err("%s: failed to register pll clock %s : %d\n",
		__func__, pll_clk->name, ret);
		kfree(pll->rate_table);
		kfree(pll);
		return;
		}