Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0071840 authored by Bryan Whitehead's avatar Bryan Whitehead Committed by David S. Miller
Browse files

lan743x: Remove phy_read from link status change function 



It has been noticed that some phys do not have the registers
required by the previous implementation.

To fix this, instead of using phy_read, the required information
is extracted from the phy_device structure.

fixes: 23f0703c ("lan743x: Add main source files for new lan743x driver")
Signed-off-by: default avatarBryan Whitehead <Bryan.Whitehead@microchip.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b7ea4894

drivers/net/ethernet/microchip/lan743x_main.c

+4 −7
Original line number Diff line number Diff line
@@ -962,13 +962,10 @@ static void lan743x_phy_link_status_change(struct net_device *netdev) 


		memset(&ksettings, 0, sizeof(ksettings));

		phy_ethtool_get_link_ksettings(netdev, &ksettings);

		local_advertisement = phy_read(phydev, MII_ADVERTISE);

		if (local_advertisement < 0)

			return;



		remote_advertisement = phy_read(phydev, MII_LPA);

		if (remote_advertisement < 0)

			return;

		local_advertisement =

			linkmode_adv_to_mii_adv_t(phydev->advertising);

		remote_advertisement =

			linkmode_adv_to_mii_adv_t(phydev->lp_advertising);



		lan743x_phy_update_flowcontrol(adapter,

					       ksettings.base.duplex,