Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ff3a5c8 authored by David Riley's avatar David Riley Committed by Gerd Hoffmann
Browse files

drm/virtio: Add memory barriers for capset cache. 



After data is copied to the cache entry, atomic_set is used indicate
that the data is the entry is valid without appropriate memory barriers.
Similarly the read side was missing the corresponding memory barriers.

Signed-off-by: default avatarDavid Riley <davidriley@chromium.org>
Link: http://patchwork.freedesktop.org/patch/msgid/20190610211810.253227-5-davidriley@chromium.org


Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 47b757fb

drivers/gpu/drm/virtio/virtgpu_ioctl.c

+3 −0
Original line number Diff line number Diff line
@@ -540,6 +540,9 @@ static int virtio_gpu_get_caps_ioctl(struct drm_device *dev, 
	if (!ret)

		return -EBUSY;



	/* is_valid check must proceed before copy of the cache entry. */

	smp_rmb();



	ptr = cache_ent->caps_cache;



	if (copy_to_user(u64_to_user_ptr(args->addr), ptr, size))

drivers/gpu/drm/virtio/virtgpu_vq.c

+2 −0
Original line number Diff line number Diff line
@@ -593,6 +593,8 @@ static void virtio_gpu_cmd_capset_cb(struct virtio_gpu_device *vgdev, 
		    cache_ent->id == le32_to_cpu(cmd->capset_id)) {

			memcpy(cache_ent->caps_cache, resp->capset_data,

			       cache_ent->size);

			/* Copy must occur before is_valid is signalled. */

			smp_wmb();

			atomic_set(&cache_ent->is_valid, 1);

			break;

		}