Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9fa24625 authored by Dave Airlie's avatar Dave Airlie
Browse files

Revert "drm/i915/fbdev: Actually configure untiled displays" 

This reverts commit d179b88d.

This commit is documented to break userspace X.org modesetting driver in certain configurations.

The X.org modesetting userspace driver is broken. No fixes are available yet. In order for this patch to be applied it either needs a config option or a workaround developed.

This has been reported a few times, saying it's a userspace problem is clearly against the regression rules.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109806


Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Cc: <stable@vger.kernel.org> # v3.19+
parent 085b7755

drivers/gpu/drm/i915/intel_fbdev.c

+5 −7
Original line number Diff line number Diff line
@@ -338,8 +338,8 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper, 
				    bool *enabled, int width, int height)

{

	struct drm_i915_private *dev_priv = to_i915(fb_helper->dev);

	unsigned long conn_configured, conn_seq, mask;

	unsigned int count = min(fb_helper->connector_count, BITS_PER_LONG);

	unsigned long conn_configured, conn_seq;

	int i, j;

	bool *save_enabled;

	bool fallback = true, ret = true;
@@ -357,9 +357,10 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper, 
		drm_modeset_backoff(&ctx);



	memcpy(save_enabled, enabled, count);

	conn_seq = GENMASK(count - 1, 0);

	mask = GENMASK(count - 1, 0);

	conn_configured = 0;

retry:

	conn_seq = conn_configured;

	for (i = 0; i < count; i++) {

		struct drm_fb_helper_connector *fb_conn;

		struct drm_connector *connector;
@@ -372,8 +373,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper, 
		if (conn_configured & BIT(i))

			continue;



		/* First pass, only consider tiled connectors */

		if (conn_seq == GENMASK(count - 1, 0) && !connector->has_tile)

		if (conn_seq == 0 && !connector->has_tile)

			continue;



		if (connector->status == connector_status_connected)
@@ -477,10 +477,8 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper, 
		conn_configured |= BIT(i);

	}



	if (conn_configured != conn_seq) { /* repeat until no more are found */

		conn_seq = conn_configured;

	if ((conn_configured & mask) != mask && conn_configured != conn_seq)

		goto retry;

	}



	/*

	 * If the BIOS didn't enable everything it could, fall back to have the