Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f7d7a1d authored by Thierry Reding's avatar Thierry Reding Committed by Linus Torvalds
Browse files

drivers/rtc/rtc-tps65910.c: fix potential NULL-pointer dereference 



The interrupt handler gets the driver data associated with the RTC
device and doesn't check it for validity.  This can cause a NULL pointer
being dereferenced when and interrupt fires before the driver data was
properly set up.

Fix this by setting the driver data earlier (before the interrupt is
requested).

Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e1d60093

drivers/rtc/rtc-tps65910.c

+2 −2
Original line number Diff line number Diff line
@@ -258,6 +258,8 @@ static int tps65910_rtc_probe(struct platform_device *pdev) 
	if (ret < 0)

		return ret;



	platform_set_drvdata(pdev, tps_rtc);



	irq  = platform_get_irq(pdev, 0);

	if (irq <= 0) {

		dev_warn(&pdev->dev, "Wake up is not possible as irq = %d\n",
@@ -283,8 +285,6 @@ static int tps65910_rtc_probe(struct platform_device *pdev) 
		return ret;

	}



	platform_set_drvdata(pdev, tps_rtc);



	return 0;

}