Commit 9f7761cf authored Jun 11, 2019 by Benjamin Coddington Committed by Trond Myklebust Jul 06, 2019

NFS: Cleanup if nfs_match_client is interrupted

Don't bail out before cleaning up a new allocation if the wait for
searching for a matching nfs client is interrupted. Memory leaks.

Reported-by: <syzbot+7fe11b49c1cc30e3fce2@syzkaller.appspotmail.com>
Fixes: 950a578c ("NFS: make nfs_match_client killable")
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

parent 9026b3a9

fs/nfs/client.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -408,10 +408,10 @@ struct nfs_client nfs_get_client(const struct nfs_client_initdata cl_init)
		clp = nfs_match_client(cl_init);
		if (clp) {
		spin_unlock(&nn->nfs_client_lock);
		if (IS_ERR(clp))
		return clp;
		if (new)
		new->rpc_ops->free_client(new);
		if (IS_ERR(clp))
		return clp;
		return nfs_found_client(cl_init, clp);
		}
		if (new) {