Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f4ca14e authored by Geert Uytterhoeven's avatar Geert Uytterhoeven
Browse files

pinctrl: sh-pfc: Move SoC-specific forward declarations to sh_pfc.h 



With C=1:

    drivers/pinctrl/sh-pfc/pfc-emev2.c:1695:30: warning: symbol 'emev2_pinmux_info' was not declared. Should it be static?
    drivers/pinctrl/sh-pfc/pfc-r8a7779.c:3888:30: warning: symbol 'r8a7779_pinmux_info' was not declared. Should it be static?

Note that there are more warnings on SH.

The sh_pfc_soc_info structure is defined in sh_pfc.h, while all forward
declarations for the SoC-specific versions are in core.h.
Move the forward declarations from core.h to sh_pfc.h to fix this.

Reported-by: default avatarBen Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 7075b30d

drivers/pinctrl/sh-pfc/core.h

+0 −24
Original line number Diff line number Diff line
@@ -67,28 +67,4 @@ void sh_pfc_write_reg(struct sh_pfc *pfc, u32 reg, unsigned int width, 
int sh_pfc_get_pin_index(struct sh_pfc *pfc, unsigned int pin);

int sh_pfc_config_mux(struct sh_pfc *pfc, unsigned mark, int pinmux_type);



extern const struct sh_pfc_soc_info emev2_pinmux_info;

extern const struct sh_pfc_soc_info r8a73a4_pinmux_info;

extern const struct sh_pfc_soc_info r8a7740_pinmux_info;

extern const struct sh_pfc_soc_info r8a7778_pinmux_info;

extern const struct sh_pfc_soc_info r8a7779_pinmux_info;

extern const struct sh_pfc_soc_info r8a7790_pinmux_info;

extern const struct sh_pfc_soc_info r8a7791_pinmux_info;

extern const struct sh_pfc_soc_info r8a7793_pinmux_info;

extern const struct sh_pfc_soc_info r8a7794_pinmux_info;

extern const struct sh_pfc_soc_info r8a7795_pinmux_info;

extern const struct sh_pfc_soc_info sh7203_pinmux_info;

extern const struct sh_pfc_soc_info sh7264_pinmux_info;

extern const struct sh_pfc_soc_info sh7269_pinmux_info;

extern const struct sh_pfc_soc_info sh73a0_pinmux_info;

extern const struct sh_pfc_soc_info sh7720_pinmux_info;

extern const struct sh_pfc_soc_info sh7722_pinmux_info;

extern const struct sh_pfc_soc_info sh7723_pinmux_info;

extern const struct sh_pfc_soc_info sh7724_pinmux_info;

extern const struct sh_pfc_soc_info sh7734_pinmux_info;

extern const struct sh_pfc_soc_info sh7757_pinmux_info;

extern const struct sh_pfc_soc_info sh7785_pinmux_info;

extern const struct sh_pfc_soc_info sh7786_pinmux_info;

extern const struct sh_pfc_soc_info shx3_pinmux_info;



#endif /* __SH_PFC_CORE_H__ */

drivers/pinctrl/sh-pfc/sh_pfc.h

+24 −0
Original line number Diff line number Diff line
@@ -225,6 +225,30 @@ struct sh_pfc_soc_info { 
	u32 unlock_reg;

};



extern const struct sh_pfc_soc_info emev2_pinmux_info;

extern const struct sh_pfc_soc_info r8a73a4_pinmux_info;

extern const struct sh_pfc_soc_info r8a7740_pinmux_info;

extern const struct sh_pfc_soc_info r8a7778_pinmux_info;

extern const struct sh_pfc_soc_info r8a7779_pinmux_info;

extern const struct sh_pfc_soc_info r8a7790_pinmux_info;

extern const struct sh_pfc_soc_info r8a7791_pinmux_info;

extern const struct sh_pfc_soc_info r8a7793_pinmux_info;

extern const struct sh_pfc_soc_info r8a7794_pinmux_info;

extern const struct sh_pfc_soc_info r8a7795_pinmux_info;

extern const struct sh_pfc_soc_info sh7203_pinmux_info;

extern const struct sh_pfc_soc_info sh7264_pinmux_info;

extern const struct sh_pfc_soc_info sh7269_pinmux_info;

extern const struct sh_pfc_soc_info sh73a0_pinmux_info;

extern const struct sh_pfc_soc_info sh7720_pinmux_info;

extern const struct sh_pfc_soc_info sh7722_pinmux_info;

extern const struct sh_pfc_soc_info sh7723_pinmux_info;

extern const struct sh_pfc_soc_info sh7724_pinmux_info;

extern const struct sh_pfc_soc_info sh7734_pinmux_info;

extern const struct sh_pfc_soc_info sh7757_pinmux_info;

extern const struct sh_pfc_soc_info sh7785_pinmux_info;

extern const struct sh_pfc_soc_info sh7786_pinmux_info;

extern const struct sh_pfc_soc_info shx3_pinmux_info;



/* -----------------------------------------------------------------------------

 * Helper macros to create pin and port lists

 */