Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f30b674 authored by Fabian Frederick's avatar Fabian Frederick Committed by Christoph Hellwig
Browse files

bfa: replace 2 kzalloc/copy_from_user by memdup_user 



This patch also removes unnecessary printk(KERN_INFO

Signed-off-by: default avatarFabian Frederick <fabf@skynet.be>
Acked-by: default avatarAnil Gurumurthy <anil.gurumurthy@qlogic.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 1b33ef23

drivers/scsi/bfa/bfad_debugfs.c

+6 −24
Original line number Diff line number Diff line
@@ -260,18 +260,9 @@ bfad_debugfs_write_regrd(struct file *file, const char __user *buf, 
	unsigned long flags;

	void *kern_buf;



	kern_buf = kzalloc(nbytes, GFP_KERNEL);



	if (!kern_buf) {

		printk(KERN_INFO "bfad[%d]: Failed to allocate buffer\n",

				bfad->inst_no);

		return -ENOMEM;

	}



	if (copy_from_user(kern_buf, (void  __user *)buf, nbytes)) {

		kfree(kern_buf);

		return -ENOMEM;

	}

	kern_buf = memdup_user(buf, nbytes);

	if (IS_ERR(kern_buf))

		return PTR_ERR(kern_buf);



	rc = sscanf(kern_buf, "%x:%x", &addr, &len);

	if (rc < 2) {
@@ -336,18 +327,9 @@ bfad_debugfs_write_regwr(struct file *file, const char __user *buf, 
	unsigned long flags;

	void *kern_buf;



	kern_buf = kzalloc(nbytes, GFP_KERNEL);



	if (!kern_buf) {

		printk(KERN_INFO "bfad[%d]: Failed to allocate buffer\n",

				bfad->inst_no);

		return -ENOMEM;

	}



	if (copy_from_user(kern_buf, (void  __user *)buf, nbytes)) {

		kfree(kern_buf);

		return -ENOMEM;

	}

	kern_buf = memdup_user(buf, nbytes);

	if (IS_ERR(kern_buf))

		return PTR_ERR(kern_buf);



	rc = sscanf(kern_buf, "%x:%x", &addr, &val);

	if (rc < 2) {