Commit 9f0a0a38 authored Aug 21, 2018 by Houlong Wei Committed by Jassi Brar Sep 29, 2018

mailbox: mediatek: Add check for possible failure of kzalloc



The patch 623a6143("mailbox: mediatek: Add Mediatek CMDQ driver")
introduce the following static checker warning:
  drivers/mailbox/mtk-cmdq-mailbox.c:366 cmdq_mbox_send_data()
  error: potential null dereference 'task'.  (kzalloc returns null)

Fixes: 623a6143 ("mailbox: mediatek: Add Mediatek CMDQ driver")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Houlong Wei <houlong.wei@mediatek.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>

parent 462f668e

drivers/mailbox/mtk-cmdq-mailbox.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -363,6 +363,9 @@ static int cmdq_mbox_send_data(struct mbox_chan chan, void data)
		WARN_ON(cmdq->suspended);

		task = kzalloc(sizeof(*task), GFP_ATOMIC);
		if (!task)
		return -ENOMEM;

		task->cmdq = cmdq;
		INIT_LIST_HEAD(&task->list_entry);
		task->pa_base = pkt->pa_base;