Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ef03193 authored by Thomas Huth's avatar Thomas Huth Committed by Michael Ellerman
Browse files

powerpc/rtas: Replace magic values with defines 



rtas.h already has some nice #defines for RTAS return status
codes - let's use them instead of hard-coded "magic" values!

Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Reviewed-by: default avatarTyrel Datwyler <tyreld@linux.vnet.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 79cd9520

arch/powerpc/kernel/rtas.c

+5 −3
Original line number Diff line number Diff line
@@ -478,8 +478,9 @@ unsigned int rtas_busy_delay_time(int status) 


	if (status == RTAS_BUSY) {

		ms = 1;

	} else if (status >= 9900 && status <= 9905) {

		order = status - 9900;

	} else if (status >= RTAS_EXTENDED_DELAY_MIN &&

		   status <= RTAS_EXTENDED_DELAY_MAX) {

		order = status - RTAS_EXTENDED_DELAY_MIN;

		for (ms = 1; order > 0; order--)

			ms *= 10;

	}
@@ -641,7 +642,8 @@ int rtas_set_indicator_fast(int indicator, int index, int new_value) 


	rc = rtas_call(token, 3, 1, NULL, indicator, index, new_value);



	WARN_ON(rc == -2 || (rc >= 9900 && rc <= 9905));

	WARN_ON(rc == RTAS_BUSY || (rc >= RTAS_EXTENDED_DELAY_MIN &&

				    rc <= RTAS_EXTENDED_DELAY_MAX));



	if (rc < 0)

		return rtas_error_rc(rc);