Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ea6b821 authored by Rob Herring's avatar Rob Herring
Browse files

dt-bindings: arm: Limit cpus schema to only check Arm 'cpu' nodes 



Matching on the 'cpus' node was a bad choice because the schema is
incorrectly applied to non-Arm cpus nodes. As we now have a common cpus
schema which checks the general structure, it is also redundant to do so
in the Arm CPU schema.

The downside is one could conceivably mix different architecture's cpu
nodes or have typos in the compatible string. The latter problem pretty
much exists for every schema.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent ef4db28c

Documentation/devicetree/bindings/arm/cpus.yaml

+224 −263
Original line number Diff line number Diff line
@@ -39,39 +39,6 @@ description: |+ 
  described below.



properties:

  $nodename:

    const: cpus

    description: Container of cpu nodes



  '#address-cells':

    enum: [1, 2]

    description: |

      Definition depends on ARM architecture version and configuration:



      On uniprocessor ARM architectures previous to v7

        value must be 1, to enable a simple enumeration

        scheme for processors that do not have a HW CPU

        identification register.

      On 32-bit ARM 11 MPcore, ARM v7 or later systems

        value must be 1, that corresponds to CPUID/MPIDR

        registers sizes.

      On ARM v8 64-bit systems value should be set to 2,

        that corresponds to the MPIDR_EL1 register size.

        If MPIDR_EL1[63:32] value is equal to 0 on all CPUs

        in the system, #address-cells can be set to 1, since

        MPIDR_EL1[63:32] bits are not used for CPUs

        identification.



  '#size-cells':

    const: 0



patternProperties:

  '^cpu@[0-9a-f]+$':

    type: object

    properties:

      device_type:

        const: cpu



  reg:

    maxItems: 1

    description: |
@@ -117,8 +84,7 @@ patternProperties: 
      All other bits in the reg cells must be set to 0.



  compatible:

        items:

          - enum:

    enum:

      - arm,arm710t

      - arm,arm720t

      - arm,arm740t
@@ -308,13 +274,8 @@ patternProperties: 
  - compatible



dependencies:

      cpu-release-addr: [enable-method]

  rockchip,pmu: [enable-method]



required:

  - '#address-cells'

  - '#size-cells'



examples:

  - |

    cpus {