Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e16d735 authored by Su Hui's avatar Su Hui Committed by Greg Kroah-Hartman
Browse files

wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger() 



[ Upstream commit c511a9c12674d246916bb16c479d496b76983193 ]

Clang Static Checker (scan-build) warns:

drivers/net/wireless/ath/ath10k/debugfs_sta.c:line 429, column 3
Value stored to 'ret' is never read.

Return 'ret' rather than 'count' when 'ret' stores an error code.

Fixes: ee8b08a1 ("ath10k: add debugfs support to get per peer tids log via tracing")
Signed-off-by: default avatarSu Hui <suhui@nfschina.com>
Acked-by: default avatarJeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240422034243.938962-1-suhui@nfschina.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 15650ffd

drivers/net/wireless/ath/ath10k/debugfs_sta.c

+1 −1
Original line number Diff line number Diff line
@@ -438,7 +438,7 @@ ath10k_dbg_sta_write_peer_debug_trigger(struct file *file, 
	}

out:

	mutex_unlock(&ar->conf_mutex);

	return count;

	return ret ?: count;

}



static const struct file_operations fops_peer_debug_trigger = {