Commit 9def249d authored Aug 15, 2019 by Quentin Monnet Committed by Alexei Starovoitov Aug 15, 2019

tools: bpftool: fix arguments for p_err() in do_event_pipe()

The last argument passed to some calls to the p_err() functions is not
correct, it should be "*argv" instead of "**argv". This may lead to a
segmentation fault error if CPU IDs or indices from the command line
cannot be parsed correctly. Let's fix this.

Fixes: f412eed9 ("tools: bpftool: add simple perf event output reader")
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

parent dadb81d0

tools/bpf/bpftool/map_perf_ring.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -157,7 +157,7 @@ int do_event_pipe(int argc, char **argv)
		NEXT_ARG();
		ctx.cpu = strtoul(*argv, &endptr, 0);
		if (*endptr) {
		p_err("can't parse %s as CPU ID", **argv);
		p_err("can't parse %s as CPU ID", *argv);
		goto err_close_map;
		}

		@@ -168,7 +168,7 @@ int do_event_pipe(int argc, char **argv)
		NEXT_ARG();
		ctx.idx = strtoul(*argv, &endptr, 0);
		if (*endptr) {
		p_err("can't parse %s as index", **argv);
		p_err("can't parse %s as index", *argv);
		goto err_close_map;
		}