Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9dbf7e34 authored by Andrej Shadura's avatar Andrej Shadura Committed by Greg Kroah-Hartman
Browse files

HID: u2fzero: ignore incomplete packets without data 

commit 22d65765f211cc83186fd8b87521159f354c0da9 upstream.

Since the actual_length calculation is performed unsigned, packets
shorter than 7 bytes (e.g. packets without data or otherwise truncated)
or non-received packets ("zero" bytes) can cause buffer overflow.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=214437


Fixes: 42337b9d("HID: add driver for U2F Zero built-in LED and RNG")
Signed-off-by: default avatarAndrej Shadura <andrew.shadura@collabora.co.uk>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d518ea03

drivers/hid/hid-u2fzero.c

+3 −1
Original line number Diff line number Diff line
@@ -198,7 +198,9 @@ static int u2fzero_rng_read(struct hwrng *rng, void *data, 
	}



	ret = u2fzero_recv(dev, &req, &resp);

	if (ret < 0)



	/* ignore errors or packets without data */

	if (ret < offsetof(struct u2f_hid_msg, init.data))

		return 0;



	/* only take the minimum amount of data it is safe to take */