Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9dac6232 authored by Govindarajulu Varadarajan's avatar Govindarajulu Varadarajan Committed by David S. Miller
Browse files

enic: free all rq buffs when allocation fails 



When allocation of all RQs fail, we do not free previously allocated buffers,
before returning error. This causes memory leak.

This patch fixes this by calling vnic_rq_clean(), which frees all the rq
buffers.

Signed-off-by: default avatarGovindarajulu Varadarajan <_govind@gmx.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 531ad428

drivers/net/ethernet/cisco/enic/enic_main.c

+4 −2
Original line number Diff line number Diff line
@@ -1616,7 +1616,7 @@ static int enic_open(struct net_device *netdev) 
		if (vnic_rq_desc_used(&enic->rq[i]) == 0) {

			netdev_err(netdev, "Unable to alloc receive buffers\n");

			err = -ENOMEM;

			goto err_out_notify_unset;

			goto err_out_free_rq;

		}

	}
@@ -1649,7 +1649,9 @@ static int enic_open(struct net_device *netdev) 


	return 0;



err_out_notify_unset:

err_out_free_rq:

	for (i = 0; i < enic->rq_count; i++)

		vnic_rq_clean(&enic->rq[i], enic_free_rq_buf);

	enic_dev_notify_unset(enic);

err_out_free_intr:

	enic_free_intr(enic);