Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d97610e authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

greybus: svc: fix an error handling bug in gb_svc_hello() 

commit 5f8583a3b7552092582a92e7bbd2153319929ad7 upstream.

Cleanup if gb_svc_queue_deferred_request() fails.

Link: https://lore.kernel.org/r/20220202072016.GA6748@kili


Fixes: ee2f2074 ("greybus: svc: reconfig APBridgeA-Switch link to handle required load")
Cc: stable@vger.kernel.org      # 4.9
[johan: fix commit summary prefix and rename label ]
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20220202113347.1288-2-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 46875750

drivers/greybus/svc.c

+7 −1
Original line number Diff line number Diff line
@@ -866,8 +866,14 @@ static int gb_svc_hello(struct gb_operation *op) 


	gb_svc_debugfs_init(svc);



	return gb_svc_queue_deferred_request(op);

	ret = gb_svc_queue_deferred_request(op);

	if (ret)

		goto err_remove_debugfs;



	return 0;



err_remove_debugfs:

	gb_svc_debugfs_exit(svc);

err_unregister_device:

	gb_svc_watchdog_destroy(svc);

	device_del(&svc->dev);