Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d108841 authored by David S. Miller's avatar David S. Miller
Browse files

Merge branch 'devlink-port-flavours-and-phys_port_name' 



Jiri Pirko says:

====================
devlink: introduce port flavours and common phys_port_name generation

This patchset resolves 2 issues we have right now:
1) There are many netdevices / ports in the system, for port, pf, vf
   represenatation but the user has no way to see which is which
2) The ndo_get_phys_port_name is implemented in each driver separatelly,
   which may lead to inconsistent names between drivers.

This patchset introduces port flavours which should address the first
problem. In this initial patchset, I focus on DSA and their port
flavours. As a follow-up, I plan to add PF and VF representor flavours.
However, that needs additional dependencies in drivers (nfp, mlx5).

The common phys_port_name generation is used by mlxsw. An example output
for mlxsw looks like this:

...
pci/0000:03:00.0/59: type eth netdev enp3s0np4 flavour physical number 4
pci/0000:03:00.0/61: type eth netdev enp3s0np1 flavour physical number 1
pci/0000:03:00.0/63: type eth netdev enp3s0np2 flavour physical number 2
pci/0000:03:00.0/49: type eth netdev enp3s0np8s0 flavour physical number 8 split_group 8 subport 0
pci/0000:03:00.0/50: type eth netdev enp3s0np8s1 flavour physical number 8 split_group 8 subport 1
pci/0000:03:00.0/51: type eth netdev enp3s0np8s2 flavour physical number 8 split_group 8 subport 2
pci/0000:03:00.0/52: type eth netdev enp3s0np8s3 flavour physical number 8 split_group 8 subport 3

As you can see, the netdev names are generated according to the flavour
and port number. In case the port is split, the split subnumber is also
included.

An example output for dsa_loop testing module looks like this:
mdio_bus/fixed-0:1f/0: type eth netdev lan1 flavour physical number 0
mdio_bus/fixed-0:1f/1: type eth netdev lan2 flavour physical number 1
mdio_bus/fixed-0:1f/2: type eth netdev lan3 flavour physical number 2
mdio_bus/fixed-0:1f/3: type eth netdev lan4 flavour physical number 3
mdio_bus/fixed-0:1f/4: type notset
mdio_bus/fixed-0:1f/5: type notset flavour cpu number 5
mdio_bus/fixed-0:1f/6: type notset
mdio_bus/fixed-0:1f/7: type notset
mdio_bus/fixed-0:1f/8: type notset
mdio_bus/fixed-0:1f/9: type notset
mdio_bus/fixed-0:1f/10: type notset
mdio_bus/fixed-0:1f/11: type notset

---
RFC->v1:
-removed nfp patches, removed DSA patch that used name generation helper
-patch 1:
 - Reduced the nfp change just to simply use newly created attr_set func
-patch 2:
 - rebased
 - removed pf/vf reps flavours
-patch 3:
 - rebased
-patch 4:
 - added missing break pointed out by Andrew
====================

Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Tested-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents eb38401c ec932fbd

drivers/net/ethernet/mellanox/mlxsw/core.c

+15 −3
Original line number Diff line number Diff line
@@ -1714,15 +1714,16 @@ EXPORT_SYMBOL(mlxsw_core_port_fini); 


void mlxsw_core_port_eth_set(struct mlxsw_core *mlxsw_core, u8 local_port,

			     void *port_driver_priv, struct net_device *dev,

			     bool split, u32 split_group)

			     u32 port_number, bool split,

			     u32 split_port_subnumber)

{

	struct mlxsw_core_port *mlxsw_core_port =

					&mlxsw_core->ports[local_port];

	struct devlink_port *devlink_port = &mlxsw_core_port->devlink_port;



	mlxsw_core_port->port_driver_priv = port_driver_priv;

	if (split)

		devlink_port_split_set(devlink_port, split_group);

	devlink_port_attrs_set(devlink_port, DEVLINK_PORT_FLAVOUR_PHYSICAL,

			       port_number, split, split_port_subnumber);

	devlink_port_type_eth_set(devlink_port, dev);

}

EXPORT_SYMBOL(mlxsw_core_port_eth_set);
@@ -1762,6 +1763,17 @@ enum devlink_port_type mlxsw_core_port_type_get(struct mlxsw_core *mlxsw_core, 
}

EXPORT_SYMBOL(mlxsw_core_port_type_get);



int mlxsw_core_port_get_phys_port_name(struct mlxsw_core *mlxsw_core,

				       u8 local_port, char *name, size_t len)

{

	struct mlxsw_core_port *mlxsw_core_port =

					&mlxsw_core->ports[local_port];

	struct devlink_port *devlink_port = &mlxsw_core_port->devlink_port;



	return devlink_port_get_phys_port_name(devlink_port, name, len);

}

EXPORT_SYMBOL(mlxsw_core_port_get_phys_port_name);



static void mlxsw_core_buf_dump_dbg(struct mlxsw_core *mlxsw_core,

				    const char *buf, size_t size)

{

drivers/net/ethernet/mellanox/mlxsw/core.h

+4 −1
Original line number Diff line number Diff line
@@ -201,13 +201,16 @@ int mlxsw_core_port_init(struct mlxsw_core *mlxsw_core, u8 local_port); 
void mlxsw_core_port_fini(struct mlxsw_core *mlxsw_core, u8 local_port);

void mlxsw_core_port_eth_set(struct mlxsw_core *mlxsw_core, u8 local_port,

			     void *port_driver_priv, struct net_device *dev,

			     bool split, u32 split_group);

			     u32 port_number, bool split,

			     u32 split_port_subnumber);

void mlxsw_core_port_ib_set(struct mlxsw_core *mlxsw_core, u8 local_port,

			    void *port_driver_priv);

void mlxsw_core_port_clear(struct mlxsw_core *mlxsw_core, u8 local_port,

			   void *port_driver_priv);

enum devlink_port_type mlxsw_core_port_type_get(struct mlxsw_core *mlxsw_core,

						u8 local_port);

int mlxsw_core_port_get_phys_port_name(struct mlxsw_core *mlxsw_core,

				       u8 local_port, char *name, size_t len);



int mlxsw_core_schedule_dw(struct delayed_work *dwork, unsigned long delay);

bool mlxsw_core_schedule_work(struct work_struct *work);

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+5 −16
Original line number Diff line number Diff line
@@ -1238,21 +1238,10 @@ static int mlxsw_sp_port_get_phys_port_name(struct net_device *dev, char *name, 
					    size_t len)

{

	struct mlxsw_sp_port *mlxsw_sp_port = netdev_priv(dev);

	u8 module = mlxsw_sp_port->mapping.module;

	u8 width = mlxsw_sp_port->mapping.width;

	u8 lane = mlxsw_sp_port->mapping.lane;

	int err;



	if (!mlxsw_sp_port->split)

		err = snprintf(name, len, "p%d", module + 1);

	else

		err = snprintf(name, len, "p%ds%d", module + 1,

			       lane / width);



	if (err >= len)

		return -EINVAL;



	return 0;

	return mlxsw_core_port_get_phys_port_name(mlxsw_sp_port->mlxsw_sp->core,

						  mlxsw_sp_port->local_port,

						  name, len);

}



static struct mlxsw_sp_port_mall_tc_entry *
@@ -2927,8 +2916,8 @@ static int mlxsw_sp_port_create(struct mlxsw_sp *mlxsw_sp, u8 local_port, 
	}



	mlxsw_core_port_eth_set(mlxsw_sp->core, mlxsw_sp_port->local_port,

				mlxsw_sp_port, dev, mlxsw_sp_port->split,

				module);

				mlxsw_sp_port, dev, module + 1,

				mlxsw_sp_port->split, lane / width);

	mlxsw_core_schedule_dw(&mlxsw_sp_port->periodic_hw_stats.update_dw, 0);

	return 0;

drivers/net/ethernet/mellanox/mlxsw/switchx2.c

+4 −7
Original line number Diff line number Diff line
@@ -417,13 +417,10 @@ static int mlxsw_sx_port_get_phys_port_name(struct net_device *dev, char *name, 
					    size_t len)

{

	struct mlxsw_sx_port *mlxsw_sx_port = netdev_priv(dev);

	int err;



	err = snprintf(name, len, "p%d", mlxsw_sx_port->mapping.module + 1);

	if (err >= len)

		return -EINVAL;



	return 0;

	return mlxsw_core_port_get_phys_port_name(mlxsw_sx_port->mlxsw_sx->core,

						  mlxsw_sx_port->local_port,

						  name, len);

}



static const struct net_device_ops mlxsw_sx_port_netdev_ops = {
@@ -1149,7 +1146,7 @@ static int __mlxsw_sx_port_eth_create(struct mlxsw_sx *mlxsw_sx, u8 local_port, 
	}



	mlxsw_core_port_eth_set(mlxsw_sx->core, mlxsw_sx_port->local_port,

				mlxsw_sx_port, dev, false, 0);

				mlxsw_sx_port, dev, module + 1, false, 0);

	mlxsw_sx->ports[local_port] = mlxsw_sx_port;

	return 0;

drivers/net/ethernet/netronome/nfp/nfp_devlink.c

+3 −2
Original line number Diff line number Diff line
@@ -175,8 +175,9 @@ int nfp_devlink_port_register(struct nfp_app *app, struct nfp_port *port) 
		return ret;



	devlink_port_type_eth_set(&port->dl_port, port->netdev);

	if (eth_port.is_split)

		devlink_port_split_set(&port->dl_port, eth_port.label_port);

	devlink_port_attrs_set(&port->dl_port, DEVLINK_PORT_FLAVOUR_PHYSICAL,

			       eth_port.label_port, eth_port.is_split,

			       eth_port.label_subport);



	devlink = priv_to_devlink(app->pf);