Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cc7a453 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

regulator: rc5t583: Fix off-by-one valid range checking for selector 



The valid selector should be 0 ... nsteps-1.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 7eb6444f

drivers/regulator/rc5t583-regulator.c

+1 −1
Original line number Diff line number Diff line
@@ -131,7 +131,7 @@ static int rc5t583_set_voltage_sel(struct regulator_dev *rdev, 
	struct rc5t583_regulator *reg = rdev_get_drvdata(rdev);

	struct rc5t583_regulator_info *ri = reg->reg_info;

	int ret;

	if (selector > ri->nsteps) {

	if (selector >= ri->nsteps) {

		dev_err(&rdev->dev, "Invalid selector 0x%02x\n", selector);

		return -EINVAL;

	}