Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cb2feb4 authored by Stafford Horne's avatar Stafford Horne Committed by Linus Torvalds
Browse files

arch/openrisc: Fix issues with access_ok() 



The commit 594cc251 ("make 'user_access_begin()' do 'access_ok()'")
exposed incorrect implementations of access_ok() macro in several
architectures.  This change fixes 2 issues found in OpenRISC.

OpenRISC was not properly using parenthesis for arguments and also using
arguments twice.  This patch fixes those 2 issues.

I test booted this patch with v5.0-rc1 on qemu and it's working fine.

Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarStafford Horne <shorne@gmail.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7b558513

arch/openrisc/include/asm/uaccess.h

+6 −2
Original line number Diff line number Diff line
@@ -59,7 +59,11 @@ 
#define __addr_ok(addr) ((unsigned long) addr < get_fs())



#define access_ok(addr, size)						\

	__range_ok((unsigned long)addr, (unsigned long)size)

({ 									\

	unsigned long __ao_addr = (unsigned long)(addr);		\

	unsigned long __ao_size = (unsigned long)(size);		\

	__range_ok(__ao_addr, __ao_size);				\

})



/*

 * These are the main single-value transfer routines.  They automatically