Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ca941d4 authored Nov 27, 2009 by Jiro SEKIBA Committed by Ryusuke Konishi Nov 27, 2009

nilfs2: delete mark_inode_dirty in nilfs_new_inode

It is redundant to call mark_inode_dirty() in nilfs_new_inode() because
all caller of nilfs_new_inode() will call mark_inode_dirty()
after calling nilfs_new_inode() directly or indirectly in transaction.

Signed-off-by: Jiro SEKIBA <jir@unicus.jp>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>

parent 0234576d

fs/nilfs2/inode.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -323,7 +323,6 @@ struct inode nilfs_new_inode(struct inode dir, int mode)
		nilfs_init_acl(), proper cancellation of
		above jobs should be considered */

		mark_inode_dirty(inode);
		return inode;

		failed_acl:

fs/nilfs2/namei.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -188,7 +188,7 @@ static int nilfs_symlink(struct inode dir, struct dentry dentry,
		goto out_fail;

		/* mark_inode_dirty(inode); */
		/* nilfs_new_inode() and page_symlink() do this */
		/* page_symlink() do this */

		err = nilfs_add_nondir(dentry, inode);
		out: