Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9c802a05 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

ipack: ipoctal: fix missing allocation-failure check 



commit 445c8132727728dc297492a7d9fc074af3e94ba3 upstream.

Add the missing error handling when allocating the transmit buffer to
avoid dereferencing a NULL pointer in write() should the allocation
ever fail.

Fixes: ba4dc61f ("Staging: ipack: add support for IP-OCTAL mezzanine board")
Cc: stable@vger.kernel.org      # 3.5
Acked-by: default avatarSamuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20210917114622.5412-5-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3fd682d4

drivers/ipack/devices/ipoctal.c

+3 −1
Original line number Diff line number Diff line
@@ -388,7 +388,9 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr, 


		channel = &ipoctal->channel[i];

		tty_port_init(&channel->tty_port);

		tty_port_alloc_xmit_buf(&channel->tty_port);

		res = tty_port_alloc_xmit_buf(&channel->tty_port);

		if (res)

			continue;

		channel->tty_port.ops = &ipoctal_tty_port_ops;



		ipoctal_reset_stats(&channel->stats);