Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b7c552b authored by Eldad Zack's avatar Eldad Zack Committed by Takashi Iwai
Browse files

ALSA: usb-audio: void return type of snd_usb_endpoint_deactivate() 



The return value of snd_usb_endpoint_deactivate() is not used,
make the function have no return value.
Update the documentation to reflect what the function is actually
doing.

Signed-off-by: default avatarEldad Zack <eldad@fogrefinery.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 239b9f79

sound/usb/endpoint.c

+5 −10
Original line number Diff line number Diff line
@@ -946,28 +946,23 @@ void snd_usb_endpoint_stop(struct snd_usb_endpoint *ep) 
 *

 * @ep: the endpoint to deactivate

 *

 * If the endpoint is not currently in use, this functions will select the

 * alternate interface setting 0 for the interface of this endpoint.

 * If the endpoint is not currently in use, this functions will

 * deactivate its associated URBs.

 *

 * In case of any active users, this functions does nothing.

 *

 * Returns an error if usb_set_interface() failed, 0 in all other

 * cases.

 */

int snd_usb_endpoint_deactivate(struct snd_usb_endpoint *ep)

void snd_usb_endpoint_deactivate(struct snd_usb_endpoint *ep)

{

	if (!ep)

		return -EINVAL;

		return;



	if (ep->use_count != 0)

		return 0;

		return;



	deactivate_urbs(ep, true);

	wait_clear_urbs(ep);



	clear_bit(EP_FLAG_ACTIVATED, &ep->flags);



	return 0;

}



/**

sound/usb/endpoint.h

+1 −1
Original line number Diff line number Diff line
@@ -22,7 +22,7 @@ int snd_usb_endpoint_start(struct snd_usb_endpoint *ep, bool can_sleep); 
void snd_usb_endpoint_stop(struct snd_usb_endpoint *ep);

void snd_usb_endpoint_sync_pending_stop(struct snd_usb_endpoint *ep);

int  snd_usb_endpoint_activate(struct snd_usb_endpoint *ep);

int  snd_usb_endpoint_deactivate(struct snd_usb_endpoint *ep);

void snd_usb_endpoint_deactivate(struct snd_usb_endpoint *ep);

void snd_usb_endpoint_free(struct list_head *head);



int snd_usb_endpoint_implicit_feedback_sink(struct snd_usb_endpoint *ep);