Commit 9b76968d authored Aug 28, 2015 by Stephen Boyd Committed by Greg Kroah-Hartman Oct 04, 2015

spmi: pmic-arb: u8 <= 0xff is always true



Silences this static checker warning:

 drivers/spmi/spmi-pmic-arb.c:363
 pmic_arb_write_cmd() warn: always true condition
 '(opc <= 255) => (0-255 <= 255)'

Cc: Andy Gross <agross@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d5144796

drivers/spmi/spmi-pmic-arb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -360,7 +360,7 @@ static int pmic_arb_write_cmd(struct spmi_controller *ctrl, u8 opc, u8 sid,
		opc = PMIC_ARB_OP_EXT_WRITE;
		else if (opc >= 0x30 && opc <= 0x37)
		opc = PMIC_ARB_OP_EXT_WRITEL;
		else if (opc >= 0x80 && opc <= 0xFF)
		else if (opc >= 0x80)
		opc = PMIC_ARB_OP_ZERO_WRITE;
		else
		return -EINVAL;