Unverified Commit 9b6d104a authored Jul 13, 2019 by Wen Yang Committed by Mark Brown Jul 16, 2019

ASoC: samsung: odroid: fix an use-after-free issue for codec



The codec variable is still being used after the of_node_put() call,
which may result in use-after-free.

Fixes: bc3cf17b ("ASoC: samsung: odroid: Add support for secondary CPU DAI")
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sangbeom Kim <sbkim73@samsung.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org
Link: https://lore.kernel.org/r/1562989575-33785-2-git-send-email-wen.yang99@zte.com.cn


Signed-off-by: Mark Brown <broonie@kernel.org>

parent ec3042ad

sound/soc/samsung/odroid.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -284,9 +284,8 @@ static int odroid_audio_probe(struct platform_device *pdev)
		}

		of_node_put(cpu);
		of_node_put(codec);
		if (ret < 0)
		return ret;
		goto err_put_node;

		ret = snd_soc_of_get_dai_link_codecs(dev, codec, codec_link);
		if (ret < 0)
		@@ -317,6 +316,7 @@ static int odroid_audio_probe(struct platform_device *pdev)
		goto err_put_clk_i2s;
		}

		of_node_put(codec);
		return 0;

		err_put_clk_i2s:
		@@ -326,6 +326,8 @@ static int odroid_audio_probe(struct platform_device *pdev)
		err_put_cpu_dai:
		of_node_put(cpu_dai);
		snd_soc_of_put_dai_link_codecs(codec_link);
		err_put_node:
		of_node_put(codec);
		return ret;
		}