Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b53238b authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Greg Kroah-Hartman
Browse files

drm/lima/lima_drv: Add missing unwind goto in lima_pdev_probe() 



[ Upstream commit c5647cae2704e58d1c4e5fedbf63f11bca6376c9 ]

Smatch reports:
drivers/gpu/drm/lima/lima_drv.c:396 lima_pdev_probe() warn:
	missing unwind goto?

Store return value in err and goto 'err_out0' which has
lima_sched_slab_fini() before returning.

Fixes: a1d2a633 ("drm/lima: driver for ARM Mali4xx GPUs")
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Signed-off-by: default avatarQiang Yu <yuq825@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230314052711.4061652-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 0a6d476d

drivers/gpu/drm/lima/lima_drv.c

+4 −2
Original line number Diff line number Diff line
@@ -300,8 +300,10 @@ static int lima_pdev_probe(struct platform_device *pdev) 


	/* Allocate and initialize the DRM device. */

	ddev = drm_dev_alloc(&lima_drm_driver, &pdev->dev);

	if (IS_ERR(ddev))

		return PTR_ERR(ddev);

	if (IS_ERR(ddev)) {

		err = PTR_ERR(ddev);

		goto err_out0;

	}



	ddev->dev_private = ldev;

	ldev->ddev = ddev;