Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b1ae605 authored by Kuehling, Felix's avatar Kuehling, Felix Committed by Jason Gunthorpe
Browse files

mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking 



Don't set this flag by default in hmm_vma_do_fault. It is set
conditionally just a few lines below. Setting it unconditionally can lead
to handle_mm_fault doing a non-blocking fault, returning -EBUSY and
unlocking mmap_sem unexpectedly.

Signed-off-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: default avatarJérôme Glisse <jglisse@redhat.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 789c2af8

mm/hmm.c

+1 −1
Original line number Diff line number Diff line
@@ -328,7 +328,7 @@ struct hmm_vma_walk { 
static int hmm_vma_do_fault(struct mm_walk *walk, unsigned long addr,

			    bool write_fault, uint64_t *pfn)

{

	unsigned int flags = FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_REMOTE;

	unsigned int flags = FAULT_FLAG_REMOTE;

	struct hmm_vma_walk *hmm_vma_walk = walk->private;

	struct hmm_range *range = hmm_vma_walk->range;

	struct vm_area_struct *vma = walk->vma;