Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 9afbb713 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Paul Burton
Browse files

mips: cavium: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paul.burton@mips.com>
Cc: James Hogan <jhogan@kernel.org>
Cc: linux-mips@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
[paul.burton@mips.com:
  Remove return 0 from init_debugfs() as pointed out by Aaro Koskinen.]
Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
parent f263f2a2

arch/mips/cavium-octeon/oct_ilm.c

+4 −28
Original line number Diff line number Diff line
@@ -63,31 +63,11 @@ static int reset_statistics(void *data, u64 value) 


DEFINE_SIMPLE_ATTRIBUTE(reset_statistics_ops, NULL, reset_statistics, "%llu\n");



static int init_debufs(void)

static void init_debugfs(void)

{

	struct dentry *show_dentry;

	dir = debugfs_create_dir("oct_ilm", 0);

	if (!dir) {

		pr_err("oct_ilm: failed to create debugfs entry oct_ilm\n");

		return -1;

	}



	show_dentry = debugfs_create_file("statistics", 0222, dir, NULL,

					  &oct_ilm_ops);

	if (!show_dentry) {

		pr_err("oct_ilm: failed to create debugfs entry oct_ilm/statistics\n");

		return -1;

	}



	show_dentry = debugfs_create_file("reset", 0222, dir, NULL,

					  &reset_statistics_ops);

	if (!show_dentry) {

		pr_err("oct_ilm: failed to create debugfs entry oct_ilm/reset\n");

		return -1;

	}



	return 0;



	debugfs_create_file("statistics", 0222, dir, NULL, &oct_ilm_ops);

	debugfs_create_file("reset", 0222, dir, NULL, &reset_statistics_ops);

}



static void init_latency_info(struct latency_info *li, int startup)
@@ -169,11 +149,7 @@ static __init int oct_ilm_module_init(void) 
	int rc;

	int irq = OCTEON_IRQ_TIMER0 + TIMER_NUM;



	rc = init_debufs();

	if (rc) {

		WARN(1, "Could not create debugfs entries");

		return rc;

	}

	init_debugfs();



	rc = request_irq(irq, cvm_oct_ciu_timer_interrupt, IRQF_NO_THREAD,

			 "oct_ilm", 0);