Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 9ab708ae authored by Colin Ian King's avatar Colin Ian King Committed by Mark Brown
Browse files

ASoC: sgtl5000: avoid division by zero if lo_vag is zero 



In the case where lo_vag <= SGTL5000_LINE_OUT_GND_BASE, lo_vag
is set to zero and later vol_quot is computed by dividing by
lo_vag causing a division by zero error.  Fix this by avoiding
a zero division and set vol_quot to zero in this specific case
so that the lowest setting for i is correctly set.

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent dabdbe3a

sound/soc/codecs/sgtl5000.c

+1 −1
Original line number Diff line number Diff line
@@ -1218,7 +1218,7 @@ static int sgtl5000_set_power_regs(struct snd_soc_component *component) 
	 * Searching for a suitable index solving this formula:

	 * idx = 40 * log10(vag_val / lo_cagcntrl) + 15

	 */

	vol_quot = (vag * 100) / lo_vag;

	vol_quot = lo_vag ? (vag * 100) / lo_vag : 0;

	lo_vol = 0;

	for (i = 0; i < ARRAY_SIZE(vol_quot_table); i++) {

		if (vol_quot >= vol_quot_table[i])