Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a7bbea2 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Sasha Levin
Browse files

serial: max310x: Unprepare and disable clock in error path 



[ Upstream commit 61acabaae5ba58b3c32e6e90d24c2c0827fd27a8 ]

In one error case the clock may be left prepared and enabled.
Unprepare and disable clock in that case to balance state of
the hardware.

Fixes: d4d6f03c4fb3 ("serial: max310x: Try to get crystal clock rate from property")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210625153733.12911-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 664a6a90

drivers/tty/serial/max310x.c

+2 −1
Original line number Diff line number Diff line
@@ -1293,7 +1293,8 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty 
		freq = uartclk;

	if (freq == 0) {

		dev_err(dev, "Cannot get clock rate\n");

		return -EINVAL;

		ret = -EINVAL;

		goto out_clk;

	}



	if (xtal) {