Commit 9a633f3b authored Jan 16, 2019 by Wei Yongjun Committed by Ulf Hansson Feb 25, 2019

mmc: sdhci-esdhc-imx: fix return value check in sdhci_esdhc_imx_probe()



In case of error, the function devm_kzalloc() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: fadac7488064 ("mmc: sdhci-esdhc-imx: add CMDQ support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 451e3193

drivers/mmc/host/sdhci-esdhc-imx.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1500,8 +1500,8 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
		if (imx_data->socdata->flags & ESDHC_FLAG_CQHCI) {
		host->mmc->caps2 \|= MMC_CAP2_CQE \| MMC_CAP2_CQE_DCMD;
		cq_host = devm_kzalloc(&pdev->dev, sizeof(*cq_host), GFP_KERNEL);
		if (IS_ERR(cq_host)) {
		err = PTR_ERR(cq_host);
		if (!cq_host) {
		err = -ENOMEM;
		goto disable_ahb_clk;
		}