Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a589c8b authored by Jingoo Han's avatar Jingoo Han Committed by David Woodhouse
Browse files

mtd: maps: cfi_flagadm: add missing __iomem annotation 



Added missing __iomem annotation and staticized local symbols
in order to fix the following sparse warnings:

drivers/mtd/maps/cfi_flagadm.c:58:17: warning: symbol 'flagadm_map' was not declared. Should it be static?
drivers/mtd/maps/cfi_flagadm.c:64:22: warning: symbol 'flagadm_parts' was not declared. Should it be static?
drivers/mtd/maps/cfi_flagadm.c:115:18: warning: cast removes address space of expression
drivers/mtd/maps/cfi_flagadm.c:115:18: warning: incorrect type in argument 1 (different address spaces)
drivers/mtd/maps/cfi_flagadm.c:115:18:    expected void volatile [noderef] <asn:2>*addr
drivers/mtd/maps/cfi_flagadm.c:115:18:    got void *<noident>
drivers/mtd/maps/cfi_flagadm.c:126:26: warning: cast removes address space of expression
drivers/mtd/maps/cfi_flagadm.c:126:26: warning: incorrect type in argument 1 (different address spaces)
drivers/mtd/maps/cfi_flagadm.c:126:26:    expected void volatile [noderef] <asn:2>*addr
drivers/mtd/maps/cfi_flagadm.c:126:26:    got void *<noident>
drivers/mtd/maps/cfi_flagadm.c:127:36: warning: Using plain integer as NULL pointer

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent e51fb2cb

drivers/mtd/maps/cfi_flagadm.c

+5 −5
Original line number Diff line number Diff line
@@ -55,13 +55,13 @@ 
#define FLASH_PARTITION3_SIZE 0x001C0000





struct map_info flagadm_map = {

static struct map_info flagadm_map = {

		.name =		"FlagaDM flash device",

		.size =		FLASH_SIZE,

		.bankwidth =	2,

};



struct mtd_partition flagadm_parts[] = {

static struct mtd_partition flagadm_parts[] = {

	{

		.name =		"Bootloader",

		.offset	=	FLASH_PARTITION0_ADDR,
@@ -112,7 +112,7 @@ static int __init init_flagadm(void) 
		return 0;

	}



	iounmap((void *)flagadm_map.virt);

	iounmap((void __iomem *)flagadm_map.virt);

	return -ENXIO;

}
@@ -123,8 +123,8 @@ static void __exit cleanup_flagadm(void) 
		map_destroy(mymtd);

	}

	if (flagadm_map.virt) {

		iounmap((void *)flagadm_map.virt);

		flagadm_map.virt = 0;

		iounmap((void __iomem *)flagadm_map.virt);

		flagadm_map.virt = NULL;

	}

}