Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a3b9090 authored by Pablo Neira Ayuso's avatar Pablo Neira Ayuso Committed by Greg Kroah-Hartman
Browse files

netfilter: nf_tables: discard table flag update with pending basechain deletion 



commit 1bc83a019bbe268be3526406245ec28c2458a518 upstream.

Hook unregistration is deferred to the commit phase, same occurs with
hook updates triggered by the table dormant flag. When both commands are
combined, this results in deleting a basechain while leaving its hook
still registered in the core.

Fixes: 179d9ba5559a ("netfilter: nf_tables: fix table flag updates")
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 61ac7284

net/netfilter/nf_tables_api.c

+19 −1
Original line number Original line Diff line number Diff line
@@ -903,6 +903,24 @@ static void nf_tables_table_disable(struct net *net, struct nft_table *table) 
#define __NFT_TABLE_F_UPDATE		(__NFT_TABLE_F_WAS_DORMANT | \

#define __NFT_TABLE_F_UPDATE		(__NFT_TABLE_F_WAS_DORMANT | \

					 __NFT_TABLE_F_WAS_AWAKEN)

					 __NFT_TABLE_F_WAS_AWAKEN)





static bool nft_table_pending_update(const struct nft_ctx *ctx)

{

	struct nftables_pernet *nft_net = net_generic(ctx->net, nf_tables_net_id);

	struct nft_trans *trans;



	if (ctx->table->flags & __NFT_TABLE_F_UPDATE)

		return true;



	list_for_each_entry(trans, &nft_net->commit_list, list) {

		if (trans->ctx.table == ctx->table &&

		    trans->msg_type == NFT_MSG_DELCHAIN &&

		    nft_is_base_chain(trans->ctx.chain))

			return true;

	}



	return false;

}



static int nf_tables_updtable(struct nft_ctx *ctx)

static int nf_tables_updtable(struct nft_ctx *ctx)

{

{

	struct nft_trans *trans;

	struct nft_trans *trans;
@@ -920,7 +938,7 @@ static int nf_tables_updtable(struct nft_ctx *ctx) 
		return 0;

		return 0;





	/* No dormant off/on/off/on games in single transaction */

	/* No dormant off/on/off/on games in single transaction */

	if (ctx->table->flags & __NFT_TABLE_F_UPDATE)

	if (nft_table_pending_update(ctx))

		return -EINVAL;

		return -EINVAL;





	trans = nft_trans_alloc(ctx, NFT_MSG_NEWTABLE,

	trans = nft_trans_alloc(ctx, NFT_MSG_NEWTABLE,