Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a39ea43 authored by Zhang Changzhong's avatar Zhang Changzhong Committed by Greg Kroah-Hartman
Browse files

net/qla3xxx: fix potential memleak in ql3xxx_send() 



[ Upstream commit 62a7311fb96c61d281da9852dbee4712fc8c3277 ]

The ql3xxx_send() returns NETDEV_TX_OK without freeing skb in error
handling case, add dev_kfree_skb_any() to fix it.

Fixes: bd36b0ac ("qla3xxx: Add support for Qlogic 4032 chip.")
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1668675039-21138-1-git-send-email-zhangchangzhong@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a07149c1

drivers/net/ethernet/qlogic/qla3xxx.c

+1 −0
Original line number Diff line number Diff line
@@ -2476,6 +2476,7 @@ static netdev_tx_t ql3xxx_send(struct sk_buff *skb, 
					     skb_shinfo(skb)->nr_frags);

	if (tx_cb->seg_count == -1) {

		netdev_err(ndev, "%s: invalid segment count!\n", __func__);

		dev_kfree_skb_any(skb);

		return NETDEV_TX_OK;

	}