Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 99d86c8f authored by Jeff Layton's avatar Jeff Layton Committed by Steve French
Browse files

cifs: fix up CIFSSMBEcho for unaligned access 



Make sure that CIFSSMBEcho can handle unaligned fields. Also fix a minor
bug that causes this warning:

fs/cifs/cifssmb.c: In function 'CIFSSMBEcho':
fs/cifs/cifssmb.c:740: warning: large integer implicitly truncated to unsigned type

...WordCount is u8, not __le16, so no need to convert it.

This patch should apply cleanly on top of the rest of the patchset to
clean up unaligned access.

Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent bf67b9be

fs/cifs/cifssmb.c

+3 −3
Original line number Diff line number Diff line
@@ -733,9 +733,9 @@ CIFSSMBEcho(struct TCP_Server_Info *server) 


	/* set up echo request */

	smb->hdr.Tid = cpu_to_le16(0xffff);

	smb->hdr.WordCount = cpu_to_le16(1);

	smb->EchoCount = cpu_to_le16(1);

	smb->ByteCount = cpu_to_le16(1);

	smb->hdr.WordCount = 1;

	put_unaligned_le16(1, &smb->EchoCount);

	put_bcc_le(1, &smb->hdr);

	smb->Data[0] = 'a';

	smb->hdr.smb_buf_length += 3;